-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Resolvers Controller performance tuning configurations #8344
Conversation
This changes the resolvers controllers to start with a config. We expose ThreadsPerController, QPS and Burst for performance tuning as we do for pipelines controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
/assign @vdemeester |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/approve we probably want to cherry pick this one 🙏🏼 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
/lgtm |
/cherry-pick release-v0.65.x |
/cherry-pick release-v0.62.x |
/cherry-pick release-v0.59.x |
/cherry-pick release-v0.56.x |
@vdemeester: new pull request created: #8364 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vdemeester: new pull request created: #8365 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vdemeester: #8344 failed to apply on top of branch "release-v0.59.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vdemeester: #8344 failed to apply on top of branch "release-v0.56.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This changes the resolvers controllers to start with a config. We expose ThreadsPerController, QPS and Burst for performance tuning as we do for pipelines controller.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes