-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot: do not update k8s.io/* major/minor updates #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind misc
/test pull-tekton-results-build-tests /test pull-tekton-results-integration-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"This makes dependabot ignore major and minor updates to k8s.io/* modules. It will still update patch release though (0.25.1 to 0.25.2). The reason to ignore those (major/minor) is because they are usually tied to knative/pkg and this means, we usually only want to update those when knative/pkg dependencies are updated as well." -Vincent Demeester
/test tekton-results-unit-tests |
I left a suggestion of excluding tekton pipelines dependencies as well, but it might be handled in a separate pr if applicable. |
"This makes dependabot ignore major and minor updates to k8s.io/* modules. It will still update patch release though (0.25.1 to 0.25.2).
The reason to ignore those (major/minor) is because they are usually tied to knative/pkg and this means, we usually only want to update those when knative/pkg dependencies are updated as well." -Vincent Demeester
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes