improve watcher logs

[ramessesii2]

• improve watcher logs messages

/kind cleanup

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Tested your changes locally (if this is a code change)
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[tekton-robot]

Hi @ramessesii2. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ramessesii2]

cc @sayan-biswas

[enarha]

/ok-to-test

[enarha]

@ramessesii2 personally I like we have the name and the namespace as separate fields as having the combo in "knative.dev/key" is less obvious. I agree the kind is probably redundant as it's quite obvious from the "results.tekton.dev/kind" field. That's IMO. Having said that, I do not have strong objection, so if others prefer the shorter records, then OK with me.

[avinal]

+1 to Emil. Although it may seem that the fields are redundant. Having explicit common fields like name, namespace, and kind is preferable and direct. In an ideal case, a user/log parser will look out for well-known fields than a less common field injected by the knative framework.

So, IMO we should leave them as it is. The message improvement is necessary and appreciated, and if you find more instances for improvement, please do that.

[ramessesii2]

@enarha @avinal given your reviews, I propose having the keys 'namespace' & 'name' uniform throughout the watcher logs. Right now, it's sporadic.
Also, we seem to agree having "results.tekton.dev/kind" is enough for marking a kind in logs, so I'll get rid of kind keys.
Removing changes related to redundant fields in logs.

[enarha]

/approve

[avinal]

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avinal,enarha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[khrm]

/kind misc