Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add full URL to Contribution Guidelines #12

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

zkoppert
Copy link

@zkoppert zkoppert commented Aug 27, 2019

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • Pulling from a topic/feature/bugfix branch (right side).
  • Pulling against the canary branch (left side).
  • Code passes linting.
  • Code passes unit tests.
  • Code coverage is the same or better.
  • You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one.

Description

The link is broken when executing it from a pull request unless the full URL is given.

The link is broken when executing it from a pull request unless the full URL is given.
@zkoppert zkoppert requested a review from ethall August 27, 2019 18:28
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #12 into canary will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           canary      #12   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files          13       13           
  Lines         413      413           
=======================================
  Hits          326      326           
  Misses         87       87

@ethall ethall merged commit a010216 into canary Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/Contribution-guidelines-link branch August 27, 2019 21:11
@ethall ethall mentioned this pull request Aug 27, 2019
6 tasks
ethall added a commit that referenced this pull request Aug 27, 2019
* Create CODEOWNERS (#11)
* Add full URL to Contribution Guidelines (#12)
@ethall ethall mentioned this pull request Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants