Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Fixed a spelling mistake #17

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Conversation

TNorbury
Copy link

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • Pulling from a topic/feature/bugfix branch (right side).
  • Pulling against the canary branch (left side).
  • Code passes linting.
  • Code passes unit tests.
  • Code coverage is the same or better.
  • You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one. (I work at Tektronix, so I don't think I need to submit one of these)

Description

Fixed a small spelling mistake in the name_map function doc

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2019

CLA assistant check
All committers have signed the CLA.

@zkoppert
Copy link

Hey @TNorbury, Can you confirm that you have your tektronix email in your github account?

@TNorbury
Copy link
Author

@zkoppert
Yeah, my email is there. Though I have my emails set to private, do I need to change that and then set my Tek email as my "public" one?

@zkoppert
Copy link

@zkoppert
Yeah, my email is there. Though I have my emails set to private, do I need to change that and then set my Tek email as my "public" one?

I don't think so. I will get @nlynchjo to take a look at the requirements for the CLA bot to work. Hold tight. Might be until Monday.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #17 into canary will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           canary    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         589    589           
=====================================
  Hits          589    589
Impacted Files Coverage Δ
syphon/hash.py 100% <ø> (ø) ⬆️

@TNorbury
Copy link
Author

Per the changes from #18 my original change was made obsolete, however I made another change that I feel like it similar enough in scope and so I'm just going to make it part of this PR

@ethall
Copy link
Collaborator

ethall commented Sep 30, 2019

Thanks for the fix, @TNorbury!

Unfortunately you submitted your pull request a few minutes before I created PR #18, which reworded the documentation you corrected.

If you see any other typos or opportunities to extend the documentation, then don't hesitate to submit another PR. (#18 finalizes the module structure, so additional PR's won't be as dangerous to make.)

@ethall ethall closed this Sep 30, 2019
@ethall
Copy link
Collaborator

ethall commented Sep 30, 2019

Looks like I spoke too soon.

@ethall ethall reopened this Sep 30, 2019
@ethall ethall merged commit 48c4a4b into tektronix:canary Sep 30, 2019
@TNorbury TNorbury deleted the topic/spelling-mistake branch September 30, 2019 20:18
@ethall ethall mentioned this pull request Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants