Task/iotcore 122 frn composition #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| frn += ':'; | ||
| } | ||
|
|
||
| if (req.entityType) { |
There was a problem hiding this comment.
While for organization (I understand that derived form Fiware-Service header) there is not problem, take into account that:
- A single request could include more than one path (see
Madrid/Gardens/ParqueNorte, Madrid/Gardens/ParqueOesteexample at https://forge.fi-ware.org/plugins/mediawiki/wiki/fiware/index.php/Publish/Subscribe_Broker_-_Orion_Context_Broker_-_User_and_Programmers_Guide#Entity_service_paths) - A single request could involve more than one entity (e.g. an updateContext on E1 and E2 at the same time).
If the current approach is not able to cope with multi-path and multi-entity and that is not fixable in this PR (or it is not clear how to adress the issue) I'd add at least a couple of FIXME comment stating the limitations of the current approach.
There was a problem hiding this comment.
...and problably add a "tech debt" issue for not forgetting this ;)
There was a problem hiding this comment.
Created a tech-debt issue: #27 to solve it in the near future.
NTC
fgalan
pushed a commit
that referenced
this pull request
Sep 22, 2014
…tion Task/iotcore 122 frn composition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate FRN from the information in the headers.