Feature/amqps protocol #689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @StWiemann An entry to CHANGES_NEXT_RELEASE file is required before merging. Could you please open a twin PR on https://github.com/telefonicaid/iotagent-ul repo? |
fgalan
reviewed
Nov 3, 2022
| @@ -58,7 +58,7 @@ | |||
| }, | |||
| "keywords": [], | |||
| "dependencies": { | |||
| "amqplib": "~0.5.1", | |||
| "amqplib": "~0.10.3", | |||
There was a problem hiding this comment.
This should be also mentioned in the CHANGES_NEXT_RELEASE file. Something like this:
- Upgrade amqplib dependency from ~0.5.1 to ~0.10.3
@StWiemann did you take into account this feedback provided by @mapedraza , please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are going to use AMQP in a future project I changed the URI-generation a bit to enable TLS-connections.
It does not yet support client-certificates, since that isn't strictly needed in my use-case but I thought maybe somebody else might be interested in AMQPS.
I did it analogous to mqtts, even though that might confuse some people due to AMQP-Protocols 0.9.1 vs 1.0 being a very different thing. This still uses 0.9.1, nothing changed there.
The new Env would be:
- IOTA_AMQP_PROTOCOL=amqporamqpsDon't really know if the testing-part works as intended. Basically just c/p'ed from MQTT_PROTOCOL...