Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search device and group for a command using entity type when provided #1212

Merged
merged 8 commits into from
Mar 24, 2022
Merged

fix: search device and group for a command using entity type when provided #1212

merged 8 commits into from
Mar 24, 2022

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Mar 23, 2022 •
edited
Loading

fix for #1211

@AlvaroVega AlvaroVega changed the title [WIP] check contextEntity type check contextEntity type Mar 23, 2022
@AlvaroVega AlvaroVega requested a review from fgalan March 23, 2022 16:50
@AlvaroVega AlvaroVega changed the title check contextEntity type fox: search device and group for a command using entity type when provided Mar 24, 2022
@AlvaroVega AlvaroVega changed the title fox: search device and group for a command using entity type when provided [WIP] fix: search device and group for a command using entity type when provided Mar 24, 2022
@AlvaroVega AlvaroVega changed the title [WIP] fix: search device and group for a command using entity type when provided fix: search device and group for a command using entity type when provided Mar 24, 2022
@AlvaroVega AlvaroVega mentioned this pull request Mar 24, 2022
Open
fgalan
fgalan approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 4741f7b into master Mar 24, 2022
@fgalan fgalan deleted the fix/check_contextEntity_type_before_search_device_by_name branch March 24, 2022 10:22
@fgalan fgalan mentioned this pull request Mar 24, 2022
Closed
This was referenced Mar 24, 2022
Merged
Merged
@mapedraza mapedraza mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan