Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit protocol note for MQTT topics #557

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

jason-fox
Copy link
Contributor

@jason-fox
Copy link
Contributor Author

I've also included an explicit requirements.txt for ReadTheDocs because the build no longer succeeds without an explicit Jinja version. If this succeeds I can make the same change on the IoT Agent for JSON.

@fgalan
Copy link
Member

fgalan commented Apr 27, 2022

Should this PR be propagated to the rest of IOTA-related repositories?

@jason-fox
Copy link
Contributor Author

Probably, but you'll need to merge to see if readthedocs works.

@fgalan
Copy link
Member

fgalan commented Apr 27, 2022

I've also included an explicit requirements.txt for ReadTheDocs because the build no longer succeeds without an explicit Jinja version. If this succeeds I can make the same change on the IoT Agent for JSON.

I have just have a look to RTD for this project and seems to be building correctly...

imagen

@jason-fox
Copy link
Contributor Author

I guess that is because you are using an outdated python to build.

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 4d4705b into telefonicaid:master Apr 27, 2022
@AlvaroVega
Copy link
Member

AlvaroVega commented Apr 27, 2022

I guess the same should be added to others iotagents.

@jason-fox
Copy link
Contributor Author

Probably just the IoT Agent for JSON which has the same MQTT binding (unless there are others?)

@fgalan
Copy link
Member

fgalan commented Apr 27, 2022

Probably, but you'll need to merge to see if readthedocs works.

After merging the PR, it seems RTD build is working:

imagen

@AlvaroVega
Copy link
Member

I guess the same should be added to others iotagents.

It was a typo, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants