Split network-operator into operator and agent #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-strusiewiczsurmacki-mobica
requested review from
MaxRink,
Cellebyte,
chdxD1 and
schrej
as code owners
p-strusiewiczsurmacki-mobica
force-pushed
the
agent-gradual
branch
2 times, most recently
from
136e1d0
to
2b2e29c
Compare
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
force-pushed
the
agent-gradual
branch
from
2b2e29c
to
abdc55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes discussed in #121
Based on #110 and #112.
in this PR reconciler interfaces from #112 were renamed to
Adaptersand are now contained in separate packages. Additionally new podAgentwas added that uses theadaptersto configure the netwokring on the host. Based on gradual rollout #110, the workflow looks currently like this:network-operator-configuratorwatches CRDs and creates per node config (NodeConfig).network-operator-workerpod watches forNodeConfigsand if there is node config created for the node it serializes it and sends it via gRPC (localhost:50042by default) to theagent.Agent(whcihc can be run as a pod or as standalone binary) is a gRPC server - it gets the config from theworkerand configures networking, and does perform configuration-specific healthchecks (e.g. checks if FRR is active).workergets success response form theagentit's go on with common connectivity healthchecks and sets theNodeConfigresource provisioning status.