Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1467 fixed event bubbling issue #1653

Merged
merged 3 commits into from
Mar 17, 2023
Merged

fix: #1467 fixed event bubbling issue #1653

merged 3 commits into from
Mar 17, 2023

Conversation

ayeshaa-m
Copy link
Contributor

@ayeshaa-m ayeshaa-m linked an issue Mar 14, 2023 that may be closed by this pull request
Error scale-tab-nav inside scale-tab-nav #1467
Closed
@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 813f7f5
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/64143d7d2d3e6f00073da059
😎 Deploy Preview https://deploy-preview-1653--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot mentioned this pull request Mar 14, 2023
Closed
@marvinLaubenstein marvinLaubenstein requested review from marvinLaubenstein and removed request for acstll and nowseemee March 14, 2023 15:26
marvinLaubenstein
marvinLaubenstein approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Really clean and nice solution 🚀

@ayeshaa-m ayeshaa-m self-assigned this Mar 17, 2023
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Closed
@marvinLaubenstein
Copy link
Collaborator

Please delete this line too.

Bildschirm­foto 2023-03-17 um 10 56 36

@ayeshaa-m ayeshaa-m merged commit 0183965 into main Mar 17, 2023
@ayeshaa-m ayeshaa-m deleted the fix/tab-nav-1467 branch March 17, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinLaubenstein marvinLaubenstein marvinLaubenstein approved these changes

Assignees

@ayeshaa-m ayeshaa-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error scale-tab-nav inside scale-tab-nav
2 participants
@ayeshaa-m @marvinLaubenstein