Symbol instances #183
Merged
Symbol instances #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates an overrideValue for each value that differs between the symbol master and the symbol instance json from html2sketch.
|
I ran a diff between a broken export (button labels don't show up) and a working one. The working one was created by changing the button symbol master font size to 14 and then back to 16 in Sketch. The issue seems to be that the group frame of the text is set to width: 0, height: 0. The nested text layer does have the correct width and height. |
|
The broken frame is coming from html2asketch. The button shadow DOM slot-element returns a zero getBoundingClientRect. Workaround is to use a selection-based BCR if the node BCR is empty in html-to-sketch nodeTreeToSketchGroup. |
added 5 commits
April 22, 2020 10:59
|
@kig looking good, thanks! |
eeegor
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking work on completing symbol instances support.