Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown-select): ensure single dropdown open at a time #2307

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

MihailsFX1nce
Copy link
Contributor

Implement global state to track the active dropdown. Modify handleClick method to close any other open dropdown before opening the clicked one. This ensures that only one dropdown can be open at a time.

Implement global state to track the active dropdown. Modify handleClick method to close any other open dropdown before opening the clicked one. This ensures that only one dropdown can be open at a time.
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 8122b5a
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6604358e2685b60007420d3a
😎 Deploy Preview https://deploy-preview-2307--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MihailsFX1nce MihailsFX1nce changed the title feat(dropdown-select): ensure single dropdown open at a time fix(dropdown-select): ensure single dropdown open at a time Mar 28, 2024
@MihailsFX1nce
Copy link
Contributor Author

Fix is for #2285

@MihailsFX1nce
Copy link
Contributor Author

@maomaoZH , could you please provide more info, what should/have to be done to fix the job runner: https://github.com/telekom/scale/actions/runs/8454004700/job/23190806654?pr=2307

@maomaoZH maomaoZH merged commit 2ad95bd into telekom:main Mar 28, 2024
11 of 12 checks passed
@felix-ico
Copy link
Collaborator

@MihailsFX1nce there was only a visual test job failing, but this was unrelated to your code changes and rather an issue with the visual test pipeline. All the other jobs were good, thanks for the PR!

@MihailsFX1nce
Copy link
Contributor Author

@felix-ico , no problem! You are welcome! 🙂

@MihailsFX1nce
Copy link
Contributor Author

@felix-ico , how much time does it take usually to update package version?

@felix-ico
Copy link
Collaborator

@MihailsFX1nce we don't have a schedule currently, as the scale library is not under active development anymore, releases happen ad-hoc (I will bring this up in our next daily and push for a release..)

@MihailsFX1nce
Copy link
Contributor Author

@felix-ico , thank you for response! We will be looking for the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants