Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination with 0 elements #2316

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

JuliaaaaH
Copy link
Contributor

Fixes #2311

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit e572eb1
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/670fe5e5f3f67400080bd935
😎 Deploy Preview https://deploy-preview-2316--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@maomaoZH maomaoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaaaaH thanks for the PR! LGTM.

@amir-ba amir-ba assigned amir-ba and unassigned amir-ba Aug 20, 2024
@amir-ba amir-ba requested review from amir-ba and removed request for amir-ba August 20, 2024 13:27
@amir-ba amir-ba added the bug Something isn't working label Aug 27, 2024
@amir-ba amir-ba self-requested a review October 10, 2024 08:48
@amir-ba
Copy link
Collaborator

amir-ba commented Oct 16, 2024

@JuliaaaaH please merge the latest main branch in your branch to fix the visual-test issue.

@amir-ba amir-ba merged commit 42a3b36 into telekom:main Oct 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScalePagination does not disable previous navgiation when 0 items in pagination and displays "1 - 0/0"
3 participants