Update all tools dependencies and fix subsequent lint errors.

Replaces #3742

Signed-off-by: Thomas Hallgren <thomas@tada.se>

.golangci.yml

@@ -84,14 +84,14 @@ linters:
     - asciicheck
     - bidichk
     - bodyclose
+    - copyloopvar
     - cyclop
     - decorder
     - depguard
     - dogsled
     - durationcheck
     - errcheck
     - errname
-    - exportloopref
     - forbidigo
     - gochecknoglobals
     - gocognit
@@ -140,7 +140,6 @@ linters:
     - err113
     - godox
     - goimports
-    - gomnd
     - gomoddirectives
     - gosec
     - interfacebloat

cmd/traffic/cmd/manager/managerutil/envconfig_test.go

@@ -86,7 +86,6 @@ func TestEnvconfig(t *testing.T) {
 	}
 
 	for tcName, tc := range testcases {
-		tc := tc // Capture loop variable...
 		t.Run(tcName, func(t *testing.T) {
 			t.Parallel()
 			lookup := func(key string) (string, bool) {

cmd/traffic/cmd/manager/mutator/agent_injector_test.go

@@ -803,7 +803,6 @@ func TestTrafficAgentConfigGenerator(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test // pin it
 		t.Run(test.name, func(t *testing.T) {
 			runFunc(t, &test, k8sapi.Http2Probe)
 		})
@@ -1820,7 +1819,6 @@ func TestTrafficAgentInjector(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test // pin it
 		t.Run(test.name, func(t *testing.T) {
 			ctx := dlog.NewTestContext(t, false)
 			env := &managerutil.Env{

integration_test/ignored_mounts_test.go

@@ -57,7 +57,6 @@ func (s *mountsSuite) Test_IgnoredMounts() {
 	defer cancel()
 
 	for _, tt := range tests {
-		tt := tt
 		s.Run(tt.name, func() {
 			tpl := struct {
 				Annotations map[string]string

integration_test/intercept_flags_test.go

@@ -122,7 +122,6 @@ func (s *interceptFlagSuite) Test_ContainerReplace() {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		s.Run(tt.name, func() {
 			ctx := s.Context()
 			expectedOutput := regexp.MustCompile(tt.iceptName + ` from intercept at`)

integration_test/kubeconfig_extension_test.go

@@ -413,7 +413,6 @@ func (s *notConnectedSuite) Test_DNSSuffixRules() {
 	logFile := filepath.Join(filelocation.AppUserLogDir(s.Context()), "daemon.log")
 
 	for _, tt := range tests {
-		tt := tt
 		s.Run(tt.name, func() {
 			ctx := s.Context()
 			if len(tt.configIncludeSuffixes) > 0 {

integration_test/mounts_test.go

@@ -194,8 +194,6 @@ func (s *mountsSuite) Test_CollidingMounts() {
 	}
 
 	for i, tt := range tests {
-		i := i
-		tt := tt
 		s.Run(tt.name, func() {
 			ctx := s.Context()
 			require := s.Require()

integration_test/pod_cidr_test.go

@@ -73,7 +73,6 @@ func (s *podCIDRSuite) Test_PodCIDRStrategy() {
 	vFile := filepath.Join(vDir, "values.yaml")
 
 	for _, tt := range tests {
-		tt := tt
 		s.Run(tt.name, func() {
 			rq := s.Require()
 			vy, err := yaml.Marshal(tt.values)

integration_test/proxy_via_test.go

@@ -97,7 +97,6 @@ func (s *proxyViaSuite) Test_ProxyViaLoopBack() {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		s.Run(tt.name, func() {
 			rq := s.Require()
 			var vip netip.Addr

pkg/client/cli/cmd/gather_logs_test.go

@@ -63,7 +63,6 @@ func Test_gatherLogsZipFiles(t *testing.T) {
 
 	for _, tc := range testCases {
 		tcName := tc.name
-		tc := tc
 		t.Run(tcName, func(t *testing.T) {
 			var fileNames []string
 			fileNames = append(fileNames, tc.realFileNames...)
@@ -137,7 +136,6 @@ func Test_gatherLogsCopyFiles(t *testing.T) {
 	}
 	for _, tc := range testCases {
 		tcName := tc.name
-		tc := tc
 		t.Run(tcName, func(t *testing.T) {
 			if tc.outputDir == "" {
 				tc.outputDir = t.TempDir()
@@ -212,7 +210,6 @@ func Test_gatherLogsNoK8s(t *testing.T) {
 
 	for _, tc := range testCases {
 		tcName := tc.name
-		tc := tc
 		t.Run(tcName, func(t *testing.T) {
 			// Use this time to validate that the zip file says the
 			// files inside were modified after the test started.
@@ -424,7 +421,6 @@ func Test_gatherLogsSignificantPodNames(t *testing.T) {
 
 	for _, tc := range testCases {
 		tcName := tc.name
-		tc := tc
 		// We need a fresh anonymizer for each test
 		t.Run(tcName, func(t *testing.T) {
 			sigPodNames := getSignificantPodNames(tc.podName)

pkg/client/cli/cmd/legacy_command_test.go

@@ -85,7 +85,6 @@ func Test_legacyCommands(t *testing.T) {
 
 	for _, tc := range testCases {
 		tcName := tc.name
-		tc := tc
 		t.Run(tcName, func(t *testing.T) {
 			inputArgs := strings.Split(tc.inputLegacyCommand, " ")
 			genTPCmd, msg, _, err := translateLegacy(inputArgs)

pkg/client/version_test.go

@@ -100,7 +100,6 @@ func TestGetInstallMechanism(t *testing.T) {
 		return nil
 	}
 	for tcName, tcData := range testcases {
-		tcData := tcData
 		t.Run(tcName, func(t *testing.T) {
 			// Create the fake binary for our test
 			// We include the tcName in the filePath, so we don't have to worry about

pkg/filelocation/os_file_test.go

@@ -87,7 +87,6 @@ func TestUser(t *testing.T) {
 	}
 	origEnv := os.Environ()
 	for tcName, tcData := range testcases {
-		tcData := tcData
 		t.Run(tcName, func(t *testing.T) {
 			if runtime.GOOS == "windows" {
 				splitAndRejoin := func(path *string) {

pkg/matcher/headers_test.go

@@ -74,7 +74,6 @@ func Test_headers_Matches(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			hm, err := NewHeaders(tt.match)
 			assert.NoError(t, err)

pkg/subnet/bitfield256_test.go

@@ -71,7 +71,6 @@ func TestByteSet_Mask(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			gotOnes, gotValue := tt.set.Mask()
 			if gotOnes != tt.wantOnes {
@@ -107,7 +106,6 @@ func TestByteSet_String(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			if got := tt.set.String(); got != tt.want {
 				t.Errorf("String() = %v, want %v", got, tt.want)

pkg/subnet/subnet_test.go

@@ -121,7 +121,6 @@ func TestUnique(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			if got := Unique(tt.subnets); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("Unique() = %v, want %v", got, tt.want)