add is_license_status field to provide validation status #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fu Yu <fuyu@Fus-MacBook-Pro.local>
thallgren
reviewed
Nov 21, 2024
rpc/manager/manager.proto
Outdated
Comment on lines
432
to
433
| // is_license_valid indicates whether the license is valid. | ||
| bool is_license_valid = 5; |
There was a problem hiding this comment.
Suggested change
| // is_license_valid indicates whether the license is valid. | |
| bool is_license_valid = 5; | |
| bool valid = 5; |
This is a field in the structure named "License" so repeating the word "license" in the field name is redundant. Also, since it's a bool, it either is or isn't, which makes the "is" word redundant too.
Based on that, I think the name "valid" is better. This in turn makes the comment "valid indicates whether the license is valid" somewhat redundant too.
There was a problem hiding this comment.
Thanks @thallgren, I renamed it to valid
Signed-off-by: Fu Yu <fuyu@Fus-MacBook-Pro.local>
thallgren
approved these changes
Nov 21, 2024
|
I need to make this change on top of release/v2.20.3 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new field in License object to provide the if a license is valid.
Checklist
./CHANGELOG.yml.CONTRIBUTING.mdwith any special dev tricks I had to use to work on this code efficiently.