Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a KB on null reference exception from the GridRowCollection class #2006

Closed
wants to merge 14 commits into from
Closed

Add a KB on null reference exception from the GridRowCollection class #2006

wants to merge 14 commits into from

Conversation

svdimitr
Copy link
Contributor

@svdimitr svdimitr commented Mar 28, 2024 •
edited by radkostanev
Loading

@svdimitr svdimitr requested a review from a team March 28, 2024 14:27
@svdimitr svdimitr self-assigned this Mar 28, 2024
@svdimitr svdimitr requested a review from a team as a code owner March 28, 2024 14:27
yordan-mitev
yordan-mitev reviewed Mar 29, 2024
View reviewed changes
knowledge-base/grid-rowcollection-nullreference.md Outdated
res_type: kb
---

## Environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the issue is version-related, you can add the affected versions to the table. In this case, they are "3.0.0 and later".

knowledge-base/grid-rowcollection-nullreference.md Outdated Show resolved Hide resolved
knowledge-base/grid-rowcollection-nullreference.md Outdated Show resolved Hide resolved
knowledge-base/grid-rowcollection-nullreference.md Outdated Show resolved Hide resolved
@svdimitr @yordan-mitev
Update knowledge-base/grid-rowcollection-nullreference.md
1812550 
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
dimodi
dimodi reviewed Apr 2, 2024
View reviewed changes
knowledge-base/grid-rowcollection-nullreference.md Outdated

## Solution

Remove either the `Data` parameter or the `OnRead` event handler.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the developer has used OnRead for some reason, it's unlikely they will go back to Data. Thus the primary recommendation can be phrased in a different way. For example, focus on the new way to use OnRead and link the relevant documentation here. The "See Also" links are less visible by definition.

svdimitr and others added 2 commits April 2, 2024 14:20
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
e7b7b63 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
cc1d157 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
svdimitr and others added 8 commits April 2, 2024 14:20
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
d3ad845 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
9c7f747 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
f50d14b 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
de38020 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
360786f 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @yordan-mitev
Update knowledge-base/grid-rowcollection-nullreference.md
eb51802 
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
97f11b2 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-rowcollection-nullreference.md
799f7c3 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@radkostanev
Copy link
Member

@svdimitr are there any blockers preventing us from moving this ahead?

@svdimitr
Copy link
Contributor Author

@svdimitr are there any blockers preventing us from moving this ahead?

I have just been working on other things (release, Grid Virtual Scrolling revamp, another KB as PR), I hope to merge this PR by the end of the week.

@svdimitr svdimitr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello @svdimitr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@svdimitr svdimitr closed this Jul 30, 2024
@github-actions github-actions bot deleted the grid-rowcollection-nullref-kb branch July 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimodi dimodi dimodi left review comments

@yordan-mitev yordan-mitev yordan-mitev left review comments

Assignees

@svdimitr svdimitr

Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svdimitr @radkostanev @dimodi @yordan-mitev