Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KB: Add a KB on programatically filtering a Grid column bound to bool? by the null values #2270

Merged
merged 14 commits into from
Sep 12, 2024
Merged

KB: Add a KB on programatically filtering a Grid column bound to bool? by the null values #2270

merged 14 commits into from
Sep 12, 2024

Conversation

svdimitr
Copy link
Contributor

No description provided.

@svdimitr svdimitr requested a review from a team July 25, 2024 12:01
@svdimitr svdimitr self-assigned this Jul 25, 2024
@svdimitr svdimitr requested a review from a team as a code owner July 25, 2024 12:01
@svdimitr svdimitr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jul 25, 2024
@svdimitr @yordan-mitev
Update knowledge-base/grid-state-filter-nullable-bool.md
9bda183 
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Hello @svdimitr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@svdimitr @yordan-mitev
Update knowledge-base/grid-state-filter-nullable-bool.md
fe9c7c7 
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
svdimitr and others added 5 commits July 26, 2024 15:02
@svdimitr @dimodi
Update knowledge-base/grid-state-filter-nullable-bool.md
98458d1 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-state-filter-nullable-bool.md
ef51c04 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update knowledge-base/grid-state-filter-nullable-bool.md
b54a501 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr
docs(kb): polish the example as feedback suggested
7be0724
@svdimitr
docs(kb): polishing
a50e22a
@svdimitr svdimitr requested a review from dimodi July 30, 2024 13:41
dimodi
dimodi requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the most important step(s) before the code snippet. For example, the need to use an IsNull filter operator.

yordan-mitev
yordan-mitev reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider shortening the page_title.

@radkostanev
Copy link
Member

@dimodi, you've blocked this PR, but I see some changes have been addressed after and a review has been requested. Can you please assist with the remaining work, if any, so we can close this?

@dimodi dimodi merged commit a2d6392 into master Sep 12, 2024
1 check passed
@github-actions GitHub Actions
Copy link
Contributor

Here you are the link to your PR to production: 2380

@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Merged
@github-actions github-actions bot deleted the grid-filter-bool-null branch September 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimodi dimodi dimodi approved these changes

@yordan-mitev yordan-mitev yordan-mitev approved these changes

Assignees

@svdimitr svdimitr

Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svdimitr @radkostanev @dimodi @yordan-mitev