Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popup settings section #2306

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Conversation

Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Aug 5, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team August 5, 2024 12:06
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Aug 5, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner August 5, 2024 12:06
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Hello @Tsvetomir-Hr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

_contentTemplates/dropdowns/features.md Outdated Show resolved Hide resolved
_contentTemplates/dropdowns/features.md Outdated Show resolved Hide resolved
components/autocomplete/overview.md Outdated Show resolved Hide resolved
components/dropdownbutton/overview.md Outdated Show resolved Hide resolved
components/dropdownbutton/overview.md Show resolved Hide resolved
Tsvetomir-Hr and others added 4 commits August 9, 2024 08:59
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Describe parameters without starting with a verb (except for bool parameters).
  • Place default values at their correct place, except for default values that depend on the CSS theme.
  • Create popup examples that enable the number of items to change. One option is to use filtering. Another option is to use a numeric textbox that determines the number of data items.

Tsvetomir-Hr and others added 2 commits August 9, 2024 16:15
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@radkostanev radkostanev merged commit 4a76c3d into master Aug 16, 2024
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2350

@github-actions github-actions bot deleted the improve-dropdown-popup-docs branch August 16, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants