Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grid): add null checks for the AggregateResults #2331

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

ntacheva
Copy link
Contributor

@ntacheva ntacheva commented Aug 9, 2024

This covers a scenario in which the Grid initializes empty. Without the check, the logic in the FooterTemplate will throw.

@ntacheva ntacheva added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Aug 9, 2024
@ntacheva ntacheva requested a review from a team August 9, 2024 10:50
@ntacheva ntacheva self-assigned this Aug 9, 2024
@ntacheva ntacheva requested a review from a team as a code owner August 9, 2024 10:50
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello @ntacheva,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@dimodi dimodi merged commit b122c59 into master Aug 14, 2024
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2346

@github-actions github-actions bot deleted the ntacheva-patch-1 branch August 14, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants