Skip to content
This repository has been archived by the owner on Apr 11, 2018. It is now read-only.

react and react-dom as peer dependencies #10

Closed
cosminnicula opened this issue Mar 31, 2016 · 0 comments
Closed

react and react-dom as peer dependencies #10

cosminnicula opened this issue Mar 31, 2016 · 0 comments
Assignees
@rkonstantinov
Labels
enhancement

Comments

@cosminnicula
Copy link

It might be a good ideea to have react and react-dom defined as peerDependencies in package.json, as a library bundle in general should be kept as minimal as possible. Also, currently is not possible to have two versions of React used alongside facebook/react#2402
@rkonstantinov rkonstantinov self-assigned this Mar 31, 2016
@rkonstantinov rkonstantinov added this to the 1.0.0 milestone Mar 31, 2016
tsvetomir added a commit that referenced this issue Mar 31, 2016
@tsvetomir
Merge pull request #12 from telerik/fix-peerdependencies
8a23070 
fix: move react and react-dom as peer dependencies. Fixes #10
@petyosi petyosi removed this from the 1.0.0 milestone Mar 31, 2016
@petyosi petyosi mentioned this issue Apr 12, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rkonstantinov rkonstantinov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petyosi @rkonstantinov @cosminnicula