This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Implement new events for debuggable WebViews detection #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/new-api-debug
branch
from
06c5570 to
7680f28
Compare
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/new-api-debug
branch
from
7680f28 to
be480c0
Compare
|
❤️ |
| let newAvailableViews = _.differenceBy(currentlyAvailableViews, previouslyAvailableViews, "id"); | ||
| let notAvailableViews = _.differenceBy(previouslyAvailableViews, currentlyAvailableViews, "id"); | ||
|
|
||
| _.each(notAvailableViews, debugWebViewInfo => this.emit("debuggableViewLost", appIdentifier, debugWebViewInfo)); |
There was a problem hiding this comment.
I'd prefer if this lambda expression did not return the result of this.emit because we might get unexpected results in the event of this.emit returning false or undefined
There was a problem hiding this comment.
This goes for the line below too
|
👍 after addressing comments |
Implement `debuggableViewFound`, `debuggableViewLost` and `debuggableViewChanged` events that will be raised when there's a change in application's debuggable views. Add new method to Public API: `getDebuggableViews` which will return debuggable views per application on device.
rosen-vladimirov
force-pushed
the
vladimirov/new-api-debug
branch
from
be480c0 to
198ae8e
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
debuggableViewFound,debuggableViewLostanddebuggableViewChangedevents that will be raised when there's a change in application's debuggable views.