Added step size slider to Settings panel #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contributions, I will be merging this over the weekend. G |
|
Great! I was also going to add blacklist setting and update the hint css to match the latest from Vimium. |
|
That would be fantastic and would solve issue #24 I should be reachable on skype (mrwooster) if you need any assistance. |
guyht
added a commit
that referenced
this pull request
Nov 9, 2013
Added step size slider to Settings panel
|
Released in 1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step size of the the movement commands h/j/k/l are a bit too small for my taste (and possibly others). Rather than using a hardcoded value, I added a slider to the settings panel. It defaults to the old value of 60 and can move between 20 and 200 in steps of 20.