Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for seeing "request socket closed" warnings? #21

Closed
AndrewLane opened this issue May 23, 2018 · 8 comments
Closed

Reason for seeing "request socket closed" warnings? #21

AndrewLane opened this issue May 23, 2018 · 8 comments

Comments

@AndrewLane
Copy link

Hello, we are seeing "request socket closed" warnings coming from

, 'request socket closed'

However, I am ignorant as to what I'm doing wrong to create that scenario. Anything simple or obvious?

@msmol
Copy link

msmol commented May 31, 2018

I am seeing these warnings as well

Node: 10.2.1
express: 4.16.3
bunyan-middleware: 0.8.0

@msmol
Copy link

msmol commented May 31, 2018

Downgrading to Node 8.9.4 seems to disappear the warning. I will continue to investigate

@msmol
Copy link

msmol commented May 31, 2018

nodejs/node#21063

Is the root cause

@ksmithut
Copy link

So if that's the correct behavior for the 'close' event to be emitted always, perhaps this log shouldn't be a warn? or is it also indicative of warn behavior?

@msmol
Copy link

msmol commented Jun 14, 2018

@ksmithut In my opinion it should no longer be logged at all, as a warn or otherwise, since it is now a "normal" event that isn't indicative of any problem or out-of-the-ordinary situation. See: https://github.com/tellnes/bunyan-middleware/pull/22/files

@ksmithut
Copy link

@msmol I would agree, I should have looked at the existing PRs 👍

@msmol
Copy link

msmol commented Jun 14, 2018

I opened that PR 2 weeks ago now, and no sign of any activity from the project owner 🤔

michaltk added a commit to michaltk/bunyan-middleware that referenced this issue Jun 27, 2019
@tellnes
Copy link
Owner

tellnes commented Jul 29, 2019

Merged the pull request, so closing this.

@tellnes tellnes closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants