Refactor & add tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamdad
reviewed
Nov 9, 2021
|
|
||
|
|
||
| @dataclass | ||
| class USPCESource(DataSource[float]): |
There was a problem hiding this comment.
Man I love this! Our first plug-in reporter DataSource that takes in a manual input from the user!
oraclown
added a commit
that referenced
this pull request
May 10, 2022
oraclown
added a commit
that referenced
this pull request
Nov 30, 2022
Remove dead code #2, update dependencies
oraclown
added a commit
that referenced
this pull request
Jan 11, 2023
Update docs based on workgroup feedback #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conforms to the typical plugin architecture, so legacy id 41 (USPCE) now has a datasource & datafeed with tests. Also, a test for submitting that manual data with the
IntervalReporter.