Telliot Conditional Reporting (tellor is stale / max price change) #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o conditional-report bringing in pyth-usd-spot feed
akremstudy
reviewed
Dec 18, 2023
| click.echo("Reporter settings:") | ||
| click.echo(f"Max tolerated price change: {percent_change * 100}%") | ||
| click.echo(f"Value considered stale after: {stale_timeout} seconds") | ||
| click.echo(f"Transaction type: {tx_type}") |
akremstudy
reviewed
Dec 18, 2023
| @click.option( | ||
| "-pc", | ||
| "--percent-change", | ||
| help="Price change percentage for triggering a report. Default=0.01 (1%)", |
akremstudy
reviewed
Dec 18, 2023
| async def get_telliot_feed_data(self, datafeed: DataFeed[Any]) -> Optional[float]: | ||
| """Fetch spot price data from API sources and calculate a value | ||
| Returns: | ||
| - Optional[GetDataBefore]: latest data from tellor oracle |
There was a problem hiding this comment.
should current data, right?
There was a problem hiding this comment.
Was my first try, butliquity backup used getDataBefore, then I used the same so I could use the same typing. Any advantage to using getCurrentData?
akremstudy
reviewed
Dec 18, 2023
tests/conftest.py
Outdated
| @@ -159,7 +159,7 @@ def mumbai_test_cfg(): | |||
|
|
|||
| @pytest.fixture(scope="function", autouse=True) | |||
| def goerli_test_cfg(): | |||
There was a problem hiding this comment.
should this still say goerli?
akremstudy
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
left comments on minor things, otherwise lgtm. thanks, @0xSpuddy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps Taken to QA Changes
Local tests passing, and lots of sepolia testing.
This pull request is:
Where Tellor is used as a primary oracle,
telliot contitionalcan be used as the reporter of last resort for minimum liveness / heartbeat. Additionally, a price change threshold can be set so that if telliot calculates a value that is a set percentage different from the current oracle value, a new value is automatically reported.