Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual string query #752

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Fix manual string query #752

merged 4 commits into from
Feb 20, 2024

Conversation

akremstudy
Copy link
Collaborator

@akremstudy akremstudy commented Feb 20, 2024

Summary

close #750
Added sub class for StringQuery ValueType to use the new method for encoding/decoding available in the current version of eth_abi.

Steps Taken to QA Changes

Added test using a good response value from here to check encoding/decoding.

Checklist

This pull request is:

  • A documentation error, docs update, or typographical error fix
    • No tests or issue needed
  • A code fix
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a bug report issue
    • Please include tests. Fixes without tests will not be accepted unless it's related to the documentation only.
    • Please make sure docs are updated if need be
  • A feature implementation
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a feature enhancement issue
    • Please include tests
    • Please make sure docs updates are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

@akremstudy akremstudy requested a review from 0xSpuddy February 20, 2024 16:35
@0xSpuddy
Copy link
Contributor

@tkernell can you please verify that this looks good for decoding in solidity? if so, we can merge and close imo. https://mumbai.polygonscan.com/tx/0xdc8f3491948800ce41c91c54bd0afa44826db77ae52c196f527f26ab25356c99

@0xSpuddy 0xSpuddy requested a review from tkernell February 20, 2024 19:19
@tkernell
Copy link
Collaborator

looks good!

@tkernell tkernell merged commit 878b411 into main Feb 20, 2024
4 checks passed
@0xSpuddy 0xSpuddy deleted the fix-manual-stringquery branch March 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringQuery Manual Submissions not Encoding Properly
3 participants