Auto input option to Blackmagic Intensity pro 4k #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make new blackmagic Intensity Pro 4K cards works with autoselect input, is it necessary, add auto to FRAMERATE, and INPUT-MODE parameters. The problem is I don't know how to make this ONLY been possible in 4k cards and not in another blackmagic cards.
Alfro
added a commit
that referenced
this pull request
Jan 23, 2018
With this change, the framerate is set by the pipeline when we set it as 'auto'
|
I was checking, and the input-mode "auto" option IS present for decklinkvideosrc on gstreamer 1.8, so I'm adding it to the blackmagic.py bin directly. Also, the FRAMERATE option is not really a blackmagic option, but more like a gstreamer pipeline one. It does not seem we currently benefit from forcing the FRAMERATE when it is set as "auto", so I have changed the logic slightly so that when it is set as auto (or not set), the pipeline does not specify a framerate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make new blackmagic Intensity Pro 4K cards works with autoselect input, is it necessary, add auto to FRAMERATE, and INPUT-MODE parameters.
The problem is I don't know how to make this ONLY been possible in 4k cards and not in another blackmagic cards.