Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted always forcing 'archive' tag. Added 'tags' to profile tracks configuration #575

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

Alfro
Copy link
Contributor

@Alfro Alfro commented Jan 25, 2018

We have recently come across an issue Stephen reported some time ago at #435.

For Galicaster 2, we included 'archive' as a default tag on every track of the MP (manifest.xml of the MP). We think the default behavior should be not adding any tags, and letting the user configure which tags, if any, wants added to a track.

Thus, we have changed the default behavior so no tags are added if none are specified, and added the "tags" parameter to the profile configuration.

@Alfro Alfro force-pushed the bugfix_435_archive_tag_on_tracks branch from f39cd6a to 64b3c6b Compare January 25, 2018 12:30
@dpeite dpeite merged commit 575f5d7 into master Jan 25, 2018
@dpeite dpeite deleted the bugfix_435_archive_tag_on_tracks branch January 25, 2018 12:53
@Alfro Alfro changed the title Reverted always forcing 'archive' tag and adding 'tags' to profile tracks configuration Reverted always forcing 'archive' tag. Added 'tags' to profile tracks configuration Jan 25, 2018
@Alfro
Copy link
Contributor Author

Alfro commented Jan 25, 2018

Example:

# profile.ini
[data]
# ...
[track1]
# ...
tags = ['archive']
# ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants