Label docker image and remove link that breaks in some contexts. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reading this issue and peering into Docker's automated build image, maybe we should rename the args to match? Also, the README should probably be updated to show how to build locally with |
brendo
reviewed
Nov 15, 2016
| com.temando.vcs-ref=$VCS_REF \ | ||
| com.temando.vcs-url="https://github.com/temando/docker-doc-platform" \ | ||
| com.temando.vendor="Temando Pty Ltd" \ | ||
| com.temando.vcs-type="Git" |
There was a problem hiding this comment.
Could come from SOURCE_TYPE
brendo
reviewed
Nov 15, 2016
| com.temando.name="docker-doc-platform" \ | ||
| com.temando.description="Docker image for publishing Temando documentation." \ | ||
| com.temando.vcs-ref=$VCS_REF \ | ||
| com.temando.vcs-url="https://github.com/temando/docker-doc-platform" \ |
brendo
reviewed
Nov 15, 2016
| LABEL com.temando.build-date=$BUILD_DATE \ | ||
| com.temando.name="docker-doc-platform" \ | ||
| com.temando.description="Docker image for publishing Temando documentation." \ | ||
| com.temando.vcs-ref=$VCS_REF \ |
brendo
reviewed
Nov 15, 2016
| @@ -1,3 +1,13 @@ | |||
| ARG BUILD_DATE | |||
| ARG VCS_REF | |||
| LABEL com.temando.build-date=$BUILD_DATE \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a variety of labels to docker image for production of project badges.
Also, links to external files from the
README.mddon't work when the file ends up in docker hub, so removing.