Set minimum psycopg version to 3.1.14 which includes support for gevent (for locust load testing) #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddorian
requested review from
ChuckHend,
nhudson,
sjmiller609,
v0idpwn and
vrmiguel
as code owners
|
Thank you @ddorian, good call. Can we move that under the dev dependencies section in pyproject.toml? Or we could create a new "benchmarking" section in there, but I think just dev is fine. Users just importing the library wont need gevent compatibility, only folks trying to run the benchmarks. |
…nt (for locust load testing)
ddorian
force-pushed
the
minimum-psycopg-for-gevent-fix
branch
from
2b9f089
to
58e829c
Compare
|
Now it's added only in dev. |
ChuckHend
approved these changes
Mar 8, 2024
|
Thank you @ddorian ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added in 3.1.14 https://www.psycopg.org/psycopg3/docs/news.html#psycopg-3-1-14.