Port test_transaction_send & test_transaction_read #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
force-pushed
the
pg-tap
branch
3 times, most recently
from
bbd8dff to
66b826b
Compare
theory
force-pushed
the
pg-tap
branch
7 times, most recently
from
01c93db to
d4a8048
Compare
ChuckHend
approved these changes
Jun 14, 2024
v0idpwn
approved these changes
Jun 15, 2024
ChuckHend
reviewed
Jun 15, 2024
Use ISOLATION tests to manage multiple database connections. The port is pretty straightforward, although `pg_isolation_regress` is only installed on Postgres 14 and higher. So don't the `ISOLATION` variables in the `Makefile` for earlier versions. Also use the `pgxn` client so simplify the installation of `pg_partman` in `extension_ci.yml`, and remove the Rust configuration for running tests, as they are no longer used. Also: use `EXTRA_CLEAN` to add additional files to the `clean` target, rather than override the target defined by PGXS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ISOLATION tests to manage multiple database connections. The port is pretty straightforward, although
pg_isolation_regressis only installed on Postgres 14 and higher. So don't theISOLATIONvariables in theMakefilefor earlier versions.Also use the
pgxnclient so simplify the installation ofpg_partmaninextension_ci.yml, and remove the Rust configuration for running tests, as they are no longer used.Also: use
EXTRA_CLEANto add additional files to thecleantarget, rather than override the target defined by PGXS.