Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make drop queue infer queue type #319

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Make drop queue infer queue type #319

merged 12 commits into from
Oct 22, 2024

Conversation

Neptune650
Copy link
Contributor

@Neptune650 Neptune650 commented Oct 17, 2024 •
edited
Loading

/claim #302
Closes #302

This PR makes pgmq.drop_queue infer the queue type using is_partitioned and removes the partitioned argument directly.

Also removes the usage of the argument from everywhere.

@algora-pbc algora-pbc bot mentioned this pull request Oct 17, 2024
Closed
@Neptune650 Neptune650 requested a review from ChuckHend October 17, 2024 17:54
@Neptune650
Copy link
Contributor Author

@ChuckHend I have committed the changes you requested, tell me what you think

@Neptune650 Neptune650 requested a review from ChuckHend October 20, 2024 23:55
@Neptune650 Neptune650 requested a review from ChuckHend October 21, 2024 00:18
@Neptune650
Copy link
Contributor Author

Thanks for the reviews
I'd appreciate if the other PRs were checked too/merged.

@v0idpwn v0idpwn force-pushed the main branch 2 times, most recently from c84e36b to 8960d65 Compare October 22, 2024 21:36
@ChuckHend ChuckHend merged commit be39b73 into tembo-io:main Oct 22, 2024
15 of 19 checks passed
@v0idpwn
Copy link
Collaborator

v0idpwn commented Oct 22, 2024

Thanks, @Neptune650 !

@Neptune650
Copy link
Contributor Author

Neptune650 commented Oct 22, 2024 •
edited
Loading

@ChuckHend @v0idpwn Thanks! Can the bounty be paid off.
Nevermind, it just did, much appreciated! Please do check the other PRs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0idpwn v0idpwn v0idpwn approved these changes

@ChuckHend ChuckHend ChuckHend approved these changes

@theory theory Awaiting requested review from theory theory is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop queue should infer queue type
3 participants
@Neptune650 @v0idpwn @ChuckHend