Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installation Guide for PGMQ #323

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Conversation

Saturn225
Copy link
Contributor

Closes #238
/claim #238

Copy link

algora-pbc bot commented Oct 19, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Saturn225 Saturn225 force-pushed the update-docs branch 2 times, most recently from af20a29 to 29fe906 Compare October 20, 2024 16:39
@Saturn225
Copy link
Contributor Author

@ChuckHend Done!

@ChuckHend
Copy link
Member

@Saturn225 thank you, looks good! Should be able to merge once we get a chance to review the windows example.

@ChuckHend
Copy link
Member

closes #316

@Saturn225
Copy link
Contributor Author

@Saturn225 thank you, looks good! Should be able to merge once we get a chance to review the windows example.

review windows example? @ChuckHend

@Saturn225 Saturn225 requested a review from ChuckHend October 26, 2024 12:17
@ChuckHend
Copy link
Member

Yes I'd like one of us to walk through the windows example and see how it goes before accepting. I should be able to do this in the next couple days.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@ChuckHend ChuckHend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing link in the MinGW install instructions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Saturn225
Copy link
Contributor Author

@theory Thanks for review! Will push the review changes requested

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Saturn225
Copy link
Contributor Author

@ChuckHend @theory Have a another round of review on it. If any changes needed I'd like to incorporate them

@Saturn225 Saturn225 changed the title Add Installation Guide (PGXN, Windows, Mac) for PGMQ Add Installation Guide for PGMQ Oct 31, 2024
@Saturn225 Saturn225 requested a review from theory October 31, 2024 08:31
@Saturn225 Saturn225 requested a review from ChuckHend October 31, 2024 08:31
CONTRIBUTING.md Outdated
Comment on lines 68 to 71
```bash
curl -LO https://api.pgxn.org/dist/pgmq/1.4.2/pgmq-1.4.2.zip
unzip pgmq-1.4.2.zip
cd pgmq-1.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saturn225 , on windows, should this still be bash, and will the user have access to curl and unzip?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is Powershell, lets make that clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a noob on Windows, and I'm getting stuck on this part 😹

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChuckHend Yes that could make different if you go full with Windows Instructions

Copy link
Contributor Author

@Saturn225 Saturn225 Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   Invoke-WebRequest -Uri https://api.pgxn.org/dist/pgmq/1.4.2/pgmq-1.4.2.zip -OutFile pgmq-1.4.2.zip
   Expand-Archive -Path pgmq-1.4.2.zip -DestinationPath .\pgmq-1.4.2
   cd .\pgmq-1.4.2

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Saturn225 Saturn225 requested a review from ChuckHend November 3, 2024 14:55
@Saturn225
Copy link
Contributor Author

@ChuckHend I have updated the installation steps, have a look once

@ChuckHend
Copy link
Member

Waiting on @theory to respond they had requested changes.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
ChuckHend and others added 2 commits November 6, 2024 08:02
Co-authored-by: David E. Wheeler <46604+theory@users.noreply.github.com>
Co-authored-by: David E. Wheeler <46604+theory@users.noreply.github.com>
@ChuckHend ChuckHend merged commit e0c8956 into tembo-io:main Nov 6, 2024
@Saturn225 Saturn225 deleted the update-docs branch November 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation guide for multiple platforms
3 participants