-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Installation Guide for PGMQ #323
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
af20a29
to
29fe906
Compare
@ChuckHend Done! |
@Saturn225 thank you, looks good! Should be able to merge once we get a chance to review the windows example. |
closes #316 |
1e68037
to
c0da883
Compare
review windows example? @ChuckHend |
Yes I'd like one of us to walk through the windows example and see how it goes before accepting. I should be able to do this in the next couple days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add missing link in the MinGW install instructions.
c0da883
to
d57d5f5
Compare
@theory Thanks for review! Will push the review changes requested |
@ChuckHend @theory Have a another round of review on it. If any changes needed I'd like to incorporate them |
CONTRIBUTING.md
Outdated
```bash | ||
curl -LO https://api.pgxn.org/dist/pgmq/1.4.2/pgmq-1.4.2.zip | ||
unzip pgmq-1.4.2.zip | ||
cd pgmq-1.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saturn225 , on windows, should this still be bash
, and will the user have access to curl
and unzip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is Powershell, lets make that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a noob on Windows, and I'm getting stuck on this part 😹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChuckHend Yes that could make different if you go full with Windows Instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoke-WebRequest -Uri https://api.pgxn.org/dist/pgmq/1.4.2/pgmq-1.4.2.zip -OutFile pgmq-1.4.2.zip
Expand-Archive -Path pgmq-1.4.2.zip -DestinationPath .\pgmq-1.4.2
cd .\pgmq-1.4.2
fc8caa6
to
2be820e
Compare
@ChuckHend I have updated the installation steps, have a look once |
Waiting on @theory to respond they had requested changes. |
Co-authored-by: David E. Wheeler <46604+theory@users.noreply.github.com>
Co-authored-by: David E. Wheeler <46604+theory@users.noreply.github.com>
Closes #238
/claim #238