Add postgres exporter sidecar and metrics service #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmiller609
force-pushed
the
postgres-exporter-2
branch
from
be9eb76 to
3c93e2b
Compare
sjmiller609
changed the title
sjmiller609
requested review from
ryw,
ianstanton and
ChuckHend
as code owners
sjmiller609
commented
Feb 15, 2023
| debug!("Did not find primary pod is ready"); | ||
| let primary_pod = primary_pod.unwrap(); | ||
|
|
||
| if !is_postgres_ready().matches_object(Some(&primary_pod)) { |
There was a problem hiding this comment.
we wait just for postgres to be ready, not the whole pod, before creating the postgres exporter role
sjmiller609
commented
Feb 15, 2023
| @@ -45,7 +45,7 @@ impl PsqlCommand { | |||
|
|
|||
| pub async fn execute(&self) -> Result<PsqlOutput, kube::Error> { | |||
| let attach_params = AttachParams { | |||
| container: None, | |||
| container: Some("postgres".to_string()), | |||
There was a problem hiding this comment.
now we have two containers in the pod, so add the container name to psql into with kube exec
sjmiller609
commented
Feb 15, 2023
| @@ -53,6 +56,74 @@ pub fn stateful_set_from_cdb(cdb: &CoreDB) -> StatefulSet { | |||
| ..VolumeMount::default() | |||
| }, | |||
| ]); | |||
| let mut containers = vec
ianstanton
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
@sjmiller609 LGTM! Thoughts on following up with a simple 'scrape metrics' test? We could argue this is not the operator's responsibility, but I think it's good to test the metrics are served as expected.
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
…ent (#117) * move postgres-exporter out of statefulset and into deployment * fmt * fix clippy warnings, add correct connection string * change policy creation to be async * fix fmt * set postgres-exporter password as secret, refactor envvars, set role pass * remove local debug line * fixing tests * add more tests to assert deployments and secrets * adjust PolicyRule for postgres-exporter * fmt * fix possible naming collisions * move test to not have a race condition * more race condition fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.