[COR-255] CoreDB operator: don't block while waiting for pod to be ready #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmiller609
commented
Feb 15, 2023
| } | ||
| if !is_pod_ready().matches_object(Some(&primary_pod.unwrap())) { | ||
| debug!("Did not find primary pod is ready"); | ||
| return Ok(Action::requeue(Duration::from_secs(1))); |
There was a problem hiding this comment.
This is 1 second wait hardcoded, but I think it ought to be an exponential backoff, up to X seconds maximum backoff time. However, I do not know how to get the previous queue duration yet.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think they are writing to 'status', that could be a future improvement to prevent checking on stuck pods every second
sjmiller609
changed the title
sjmiller609
requested review from
ryw,
ianstanton and
ChuckHend
as code owners
sjmiller609
changed the title
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
* Derive default * Remove topology from status * Don't derive default where it doesn't work * fmt * Use stable for clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, return to the reconciler loop with a short wait.