-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COR-381] trunk publish
#214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
commented
Apr 7, 2023
Some(..) => { | ||
// If file is specified, use it | ||
let path = self.file.clone().unwrap(); | ||
let name = path.file_name().unwrap().to_str().unwrap().to_owned(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrestled with this for a bit... there's got to be a better way.
ianstanton
commented
Apr 7, 2023
// Error if file is not found | ||
let mut path = PathBuf::new(); | ||
let _ = &path.push(format!("./{}-{}.tar.gz", self.name, self.version)); | ||
let name = path.file_name().unwrap().to_str().unwrap().to_owned(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
ChuckHend
approved these changes
Apr 7, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
* Handle schema: null on toggle * Update tembo-operator/tests/integration_tests.rs * Fix flakey test: functional_test_ha_upgrade_cnpg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trunk publish
allows for publishing postgres extensions to the trunk registry. If no file is provided, the CLI will look for a file in its working dir with format<extension_name>-<version>.tar.gz
.Example: