exec trunk install #217
Merged
exec trunk install #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 7, 2023 08:24
ChuckHend
commented
Apr 7, 2023
| @@ -58,7 +58,7 @@ spec: | |||
| type: object | |||
| type: array | |||
| image: | |||
| default: quay.io/coredb/postgres:6e3c4a7 | |||
| default: quay.io/coredb/postgres:d45c5b1 | |||
There was a problem hiding this comment.
update to the image that has trunk cli installed
ChuckHend
commented
Apr 7, 2023
| @@ -367,6 +390,32 @@ fn extension_plan(have_changed: &[Extension], actual: &[Extension]) -> (Vec<Exte | |||
| (changed, to_install) | |||
| } | |||
|
|
|||
| /// reconcile extensions between the spec and the database | |||
There was a problem hiding this comment.
moved this to the bottom of the file so its easier to find. its the "top level" command in the file
ChuckHend
requested review from
ianstanton,
nhudson and
sjmiller609
as code owners
sjmiller609
approved these changes
Apr 10, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
trunk install <extension> --version <version>in postgres podsome follow up work next week: