handle create pvc events #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChuckHend
commented
Apr 11, 2023
•
ChuckHend
commented
- delete pod after new PVCs are created
added 11 commits
April 11, 2023 11:31
ChuckHend
requested review from
ianstanton,
nhudson and
sjmiller609
as code owners
ChuckHend
commented
Apr 11, 2023
Comment on lines
+427
to
429
| fn pvc_full_name(pvc_name: &str, sts_name: &str) -> String { | ||
| format!("{pvc_name}-{sts_name}-0") | ||
| } |
There was a problem hiding this comment.
moved this logic out, so we can create and use the pvc names upstream in the pvc reconcile process
sjmiller609
approved these changes
Apr 11, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.