Fix clippy CI error in coredb-cli
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@sjmiller609 To be honest I'm not sure this is the right solution. I don't think I fully understand the clippy error. |
sjmiller609
approved these changes
Apr 27, 2023
| .arg("sample-db"); | ||
| cmd.assert() | ||
| .stdout(predicate::str::contains("kind: CoreDB")); | ||
|
|
||
| let mut cmd = Command::cargo_bin(CARGO_BIN)?; | ||
| cmd.arg("create") | ||
| .arg("--dry-run") | ||
| .arg("--resource-type") |
There was a problem hiding this comment.
Is there a way to fix without changing the CLI syntax?
|
@sjmiller609 it looks like it was a derive bug resolved in a later version of |
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
* conductor: log the restartedAt annotation being set * operator: log change in `restartedAt` * Update conductor/src/lib.rs --------- Co-authored-by: Steven Miller <sjmiller609@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a clippy error has arisen as we've udpated rust version in CI. This should resolve the issue.