add pgmq integration test #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChuckHend
commented
Jan 10, 2023
ChuckHend
commented
- add an integration test for lifecycle of a single message
- add github workflow to run the tests and publish releases
ChuckHend
requested review from
ryw,
ianstanton and
sjmiller609
as code owners
ChuckHend
commented
Jan 10, 2023
ChuckHend
commented
Jan 10, 2023
Comment on lines
+57
to
+73
| # publish: | ||
| # # only publish off tag events | ||
| # if: startsWith(github.ref, 'refs/tags/') | ||
| # name: Publish Crate | ||
| # runs-on: ubuntu-22.04 | ||
| # needs: [lint, tests] | ||
| # steps: | ||
| # - uses: actions/checkout@v2 | ||
| # - name: Install Rust stable toolchain | ||
| # uses: actions-rs/toolchain@v1 | ||
| # with: | ||
| # toolchain: stable | ||
| # - uses: Swatinem/rust-cache@v2 | ||
| # - name: publish | ||
| # env: | ||
| # CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} | ||
| # run: cargo publish |
There was a problem hiding this comment.
I'll handle publishing in this workflow in separate PR.
sjmiller609
approved these changes
Jan 10, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
* update crudevent * use the spec from control plane * handle response to cp * use references * under * update test for event type
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
Co-authored-by: Adarsh Shah <github@shahadarsh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.