Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logs for cloud #481

Merged
merged 18 commits into from
Jan 25, 2024
Merged

Adding logs for cloud #481

merged 18 commits into from
Jan 25, 2024

Conversation

joshuajerin
Copy link
Contributor

No description provided.

@joshuajerin joshuajerin marked this pull request as ready for review January 17, 2024 02:27
sjmiller609
sjmiller609 reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! also adding some tests would be nice

tembo-cli/src/cmd/logs.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/logs.rs Outdated Show resolved Hide resolved
@joshuajerin joshuajerin merged commit efeb7fc into main Jan 25, 2024
3 checks passed
@joshuajerin joshuajerin deleted the logs_cloud branch January 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@shahadarsh shahadarsh Awaiting requested review from shahadarsh shahadarsh is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuajerin @sjmiller609