Assorted minor refactors and performance nits #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
commented
Jan 30, 2024
vrmiguel
commented
Jan 30, 2024
| for mut env in context.environment { | ||
| if let Some(_is_set) = env.set { | ||
| if let Some(profile) = &env.profile { | ||
| let credential = profiles.iter().rev().find(|c| &c.name == profile).unwrap(); |
There was a problem hiding this comment.
Same idea as the previous code (iterate and find the last matching element) but starting from the end, doing less work overall
vrmiguel
requested review from
shahadarsh,
DarrenBaldwin07 and
sjmiller609
as code owners
DarrenBaldwin07
approved these changes
Jan 30, 2024
| @@ -43,7 +43,7 @@ pub fn execute(verbose: bool) -> Result<(), anyhow::Error> { | |||
| let mut file_path = FileUtils::get_current_working_dir(); | |||
| file_path.push_str("/tembo.toml"); | |||
|
|
|||
| let contents = fs::read_to_string(file_path.clone())?; | |||
shahadarsh
reviewed
Jan 30, 2024
shahadarsh
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm familiaring myself with the tembo-cli code and thought it was a good opportunity to suggest these minor changes