uses tembo-stacks crate for merge logic between stacks, instance, app_services #534
Conversation
shahadarsh
changed the title
| stack.app_services.clone(), | ||
| extensions, | ||
| trunk_installs, | ||
| Option::None, |
There was a problem hiding this comment.
Skipping the pg_config merge here and using the existing logic that's there
| {% if instance.app_services.restapi %} | ||
| {{instance.instance_name}}-postgrest: | ||
| image: postgrest/postgrest:v10.0.0 | ||
| {% set_global pathPrefixes = "" -%} |
There was a problem hiding this comment.
The template is getting complex. I will look at simplifying this either by moving it to Rust or figuring out another way in the coming PRs.
There was a problem hiding this comment.
I agree, at this point it seems like we should just have a Value type constructed in rust then formatted into the yaml file
| @@ -528,6 +574,32 @@ fn get_extensions( | |||
| vec_extensions | |||
| } | |||
|
|
|||
| fn get_extensions_controller( | |||
There was a problem hiding this comment.
Now that we have tembo-stacks more types can be reused but will require significant work in CLI so need to convert it (at least for now) to use it with merge_app_reqs.
shahadarsh
requested review from
vrmiguel,
DarrenBaldwin07 and
sjmiller609
as code owners
| {% if instance.app_services.restapi %} | ||
| {{instance.instance_name}}-postgrest: | ||
| image: postgrest/postgrest:v10.0.0 | ||
| {% set_global pathPrefixes = "" -%} |
There was a problem hiding this comment.
I agree, at this point it seems like we should just have a Value type constructed in rust then formatted into the yaml file
No description provided.