Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tembologin #539

Merged
merged 15 commits into from
Feb 29, 2024
Merged

Tembologin #539

merged 15 commits into from
Feb 29, 2024

Conversation

joshuajerin
Copy link
Contributor

No description provided.

sjmiller609
sjmiller609 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please address two minor requests then good to merge if CI is green.

tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
@joshuajerin joshuajerin marked this pull request as ready for review February 23, 2024 23:37
sjmiller609
sjmiller609 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe some changes needed to have it work against anything besides prod cloud because the prod cloud domains are coded in

DarrenBaldwin07
DarrenBaldwin07 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@DarrenBaldwin07 DarrenBaldwin07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
@joshuajerin joshuajerin merged commit 4f2c07a into main Feb 29, 2024
7 checks passed
@joshuajerin joshuajerin deleted the tembologin branch February 29, 2024 16:38
@joshuajerin joshuajerin restored the tembologin branch February 29, 2024 16:56
@joshuajerin joshuajerin deleted the tembologin branch March 8, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarrenBaldwin07 DarrenBaldwin07 DarrenBaldwin07 approved these changes

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@shahadarsh shahadarsh Awaiting requested review from shahadarsh shahadarsh is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuajerin @sjmiller609 @DarrenBaldwin07