uses merge_app_reqs to merge app pg_config #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahadarsh
requested review from
vrmiguel,
DarrenBaldwin07 and
sjmiller609
as code owners
shahadarsh
commented
Feb 20, 2024
shahadarsh
commented
Feb 20, 2024
sjmiller609
approved these changes
Feb 20, 2024
tembo-cli/src/cmd/apply.rs
Outdated
| postgres_config.push_str(&val); | ||
| postgres_config.push_str(qoute_new_line); | ||
| } | ||
| ControllerConfigValue::Multiple(vals) => { |
There was a problem hiding this comment.
you may consider a test case in a future PR that checks the extension citus is listed first in shared_preload_libraries after being enabled on top of a Stack that includes other shared_preloads, like vectordb
ChuckHend
reviewed
Feb 20, 2024
vrmiguel
reviewed
Feb 20, 2024
vrmiguel
reviewed
Feb 20, 2024
vrmiguel
approved these changes
Feb 20, 2024
shahadarsh
commented
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.