Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller dependency in stacks crate #571

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ianstanton
Copy link
Member

@ianstanton ianstanton commented Feb 23, 2024

@EvanHStanton and I found that when bumping the control-plane's controller crate to 0.36.0, the Cargo.lock file pulled in two versions of the controller crate:
Related PR:

The tembo-stacks crate was showing controller 0.35.5 as a dependency. This should resolve the issue.

Multiple versions in Cargo.lock

[[package]]
name = "controller"
version = "0.35.5"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ccf3edc4f1f4872ef3a31f709753c70809cfbab2b0400d5f2754db769d436fd4"
dependencies = [
 "actix-web",
 "anyhow",
 "base64 0.21.7",
 "chrono",
 "futures",
 "itertools 0.11.0",
 "k8s-openapi",
 "kube",
 "lazy_static",
 "opentelemetry 0.19.0",
 "passwords",
 "prometheus",
 "rand 0.8.5",
 "regex",
 "reqwest",
 "schemars",
 "semver",
 "serde",
 "serde_json",
 "serde_yaml",
 "thiserror",
 "tokio",
 "tracing",
 "tracing-opentelemetry 0.19.0",
 "tracing-subscriber",
 "utoipa",
]

[[package]]
name = "controller"
version = "0.36.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1c6bdbeb72f960ddd2674a290fb911f476f14ca98ff6472257dacf763f3d4e48"
dependencies = [
 "actix-web",
 "anyhow",
 "base64 0.21.7",
 "chrono",
 "futures",
 "itertools 0.11.0",
 "k8s-openapi",
 "kube",
 "lazy_static",
 "opentelemetry 0.19.0",
 "passwords",
 "prometheus",
 "rand 0.8.5",
 "regex",
 "reqwest",
 "schemars",
 "semver",
 "serde",
 "serde_json",
 "serde_yaml",
 "thiserror",
 "tokio",
 "tracing",
 "tracing-opentelemetry 0.19.0",
 "tracing-subscriber",
 "utoipa",
]

Wrong controller version in tembo-stacks dependencies in Cargo.lock file

[[package]]
name = "tembo-stacks"
version = "0.3.5"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "9b323976d5947019e37e76fb0110b211cffc4763b7fa86acd07c644428db1aa3"
dependencies = [
 "anyhow",
 "controller 0.35.5",
 "futures",
 "k8s-openapi",
 "lazy_static",
 "schemars",
 "serde",
 "serde_yaml",
 "tracing",
 "utoipa",
]

Signed-off-by: Ian Stanton <ian@tembo.io>
Copy link
Collaborator

@shahadarsh shahadarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if the controller version doesn't match in control plane & stacks it causes issues. Same applies to CLI.

@ianstanton ianstanton merged commit dadd6c2 into main Feb 23, 2024
7 checks passed
@ianstanton ianstanton deleted the bump-tembo-stacks-controller-dependency branch February 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants