Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tembo init should not populate unconfigured profiles #624

Merged
merged 16 commits into from
Mar 28, 2024
Merged

Tembo init should not populate unconfigured profiles #624

merged 16 commits into from
Mar 28, 2024

Conversation

joshuajerin
Copy link
Contributor

No description provided.

@joshuajerin joshuajerin marked this pull request as ready for review March 13, 2024 02:43
@joshuajerin joshuajerin marked this pull request as draft March 14, 2024 03:40
@joshuajerin joshuajerin marked this pull request as ready for review March 14, 2024 20:08
@joshuajerin
Copy link
Contributor Author

Test failures will be covered in this PR cause it's being blocked

sjmiller609
sjmiller609 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for the condition being fixed?

tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cli/context.rs Outdated Show resolved Hide resolved
@joshuajerin
Copy link
Contributor Author

I'll be adding a test in this PR for these changes

@sjmiller609
Copy link
Contributor

In this PR, just fix it in this function

tembo/tembo-cli/tests/integration_tests_cloud.rs

Line 98 in cd8a139

fn setup_env(instance_name: &String) -> Result<(), Box<dyn Error>> {

@joshuajerin joshuajerin merged commit 6a29e1e into main Mar 28, 2024
7 checks passed
@joshuajerin joshuajerin deleted the cli-3257 branch March 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@shahadarsh shahadarsh Awaiting requested review from shahadarsh shahadarsh is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuajerin @sjmiller609