Revert all VolumeSnapshot related code #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
requested review from
sjmiller609,
ianstanton and
ChuckHend
as code owners
ianstanton
approved these changes
Mar 29, 2024
sjmiller609
approved these changes
Mar 29, 2024
|
After this merges and deploys to dev, I will go and delete all snapshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting all
VolumeSnapshotrelated code for now.Being that enabling snapshots cause some pretty undesirable behavior right now in our controller we need to revert back to not having it enabled.