Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stack specs with equivalent constraints #761

Merged
merged 11 commits into from
May 6, 2024
Merged

update stack specs with equivalent constraints #761

merged 11 commits into from
May 6, 2024

Conversation

ChuckHend
Copy link
Member

@ChuckHend ChuckHend commented May 6, 2024 •
edited
Loading

ML stack is the only one that has any constraints on CPU or Mem.

Depends on #760

@ChuckHend ChuckHend marked this pull request as ready for review May 6, 2024 20:29
@ChuckHend ChuckHend requested a review from jasonmp85 as a code owner May 6, 2024 20:29
jasonmp85
jasonmp85 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@jasonmp85 jasonmp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this diff.

sjmiller609
sjmiller609 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CLI might use these for locally deploying a stack

@ChuckHend
Copy link
Member Author

ChuckHend commented May 6, 2024 •
edited
Loading

I think CLI might use these for locally deploying a stack

Took a peek and couldn't find anywhere that they are used. However, it is defined in an example here

Base automatically changed from SPAE-154-0 to main May 6, 2024 21:34
@ChuckHend ChuckHend merged commit 0b6581b into main May 6, 2024
7 checks passed
@ChuckHend ChuckHend deleted the SPAE-154-1 branch May 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmp85 jasonmp85 jasonmp85 approved these changes

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@nhudson nhudson Awaiting requested review from nhudson

@ianstanton ianstanton Awaiting requested review from ianstanton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckHend @jasonmp85 @sjmiller609